uvicorn icon indicating copy to clipboard operation
uvicorn copied to clipboard

Add default code for `websocket.close`

Open Kludex opened this issue 3 years ago • 2 comments

I need to add tests for it.

Inspired by https://github.com/encode/starlette/issues/1560#issuecomment-1086855500

  • [x] ~tests~ this is actually being tested... against none and 1000... maybe we should be more restrictive on the test...

Kludex avatar Apr 05 '22 18:04 Kludex

this is actually being tested... against none and 1000... maybe we should be more restrictive on the test...

Would you mind highlighting the relevant test?

adriangb avatar May 12 '22 05:05 adriangb

are you referring to those tests @Kludex ? https://github.com/encode/uvicorn/blob/9c57549e054d8c58b53fa25217155c2f1c8ee20f/tests/protocols/test_websocket.py#L453-L492

if this is the case how come the test was not failing for wsproto ?

euri10 avatar Jun 17 '22 15:06 euri10

Working on it on another PR.

Kludex avatar Oct 31 '22 19:10 Kludex