uvicorn
uvicorn copied to clipboard
Add default code for `websocket.close`
I need to add tests for it.
Inspired by https://github.com/encode/starlette/issues/1560#issuecomment-1086855500
- [x] ~tests~ this is actually being tested... against none and 1000... maybe we should be more restrictive on the test...
this is actually being tested... against none and 1000... maybe we should be more restrictive on the test...
Would you mind highlighting the relevant test?
are you referring to those tests @Kludex ? https://github.com/encode/uvicorn/blob/9c57549e054d8c58b53fa25217155c2f1c8ee20f/tests/protocols/test_websocket.py#L453-L492
if this is the case how come the test was not failing for wsproto ?
Working on it on another PR.