starlette icon indicating copy to clipboard operation
starlette copied to clipboard

Fix: Resolve the issue where the directory itself being a symlink does not work.

Open hanxi opened this issue 1 year ago • 3 comments

Summary

Checklist

  • [x] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.

Fixed #2646

I test https://github.com/encode/starlette/security/advisories/GHSA-v5gw-mw7f-84px case. test result is 404 Not Found.

hanxi avatar Sep 29 '24 20:09 hanxi

A test case is needed here.

Kludex avatar Sep 29 '24 20:09 Kludex

Okay, I'll add the test cases.

hanxi avatar Sep 30 '24 00:09 hanxi

done.

hanxi avatar Sep 30 '24 03:09 hanxi

Thanks!

Kludex avatar Dec 01 '24 16:12 Kludex