httpx icon indicating copy to clipboard operation
httpx copied to clipboard

Published 20 hours ago • verified publisher icon encode

Support rfc3986 v2

Open Mokto opened this issue 2 years ago • 3 comments

Would be nice to support rfc3986 to that enables python 3.8,3.9,3.10 support.

https://rfc3986.readthedocs.io/en/latest/release-notes/unreleased.html

Thanks!

Mokto avatar Apr 11 '22 18:04 Mokto

@Mokto I'm curious, what changed in rfc3986 with "3.8+ support"? HTTPX can already be used on 3.8+, and it uses rfc3986 for URLs, so the latter did already work on these Python versions, right?

florimondmanca avatar Apr 12 '22 10:04 florimondmanca

No idea to be honest.

I just know httpx prevents me from updating the rfc3986 version.

Mokto avatar Apr 12 '22 12:04 Mokto

As you can see in the CI logs, v2 seems to bring changes that would need addressing. Mostly look like deprecations. Since we manage the dependency, perhaps we should switch to >=2,<3 and address those deprecations.

florimondmanca avatar Apr 12 '22 13:04 florimondmanca

Thanks for spending your time on this. Closing in favour of #2252. Let's crack on with dropping our rfc3986 dependancy.

tomchristie avatar Oct 13 '22 14:10 tomchristie