django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

Add Python 3.12 support

Open math-a3k opened this issue 1 year ago • 7 comments

This is a test for the CI of python 3.12 since I can't commit to auvipy:py312 nor make a pull request to that branch (#9157). The tests pass locally, if confirmed on the CI, @auvipy can apply the commit to his branch and then merge. Otherwise, please ignore and close.

math-a3k avatar Jan 20 '24 00:01 math-a3k

@auvipy: It turns out the changes were already committed to master, didn't see them, rebased and I fixed the blacken error so the CI passes

math-a3k avatar Jan 20 '24 01:01 math-a3k

Please rebase

cclauss avatar Jan 24 '24 22:01 cclauss

py312-django42: OK ✔ in 40.27 seconds 🚀

cclauss avatar Jan 24 '24 23:01 cclauss

I would say this is ready for review. Py3.12 is supported but Dj5 is not.

cclauss avatar Jan 24 '24 23:01 cclauss

I would say this is ready for review. Py3.12 is supported but Dj5 is not.

Can you elaborate on why not? I think if the test suite passes it in good condition to start receiving bug reports

math-a3k avatar Jan 25 '24 01:01 math-a3k

The test results are:

  py312-django42: OK (40.27=setup[15.62]+cmd[24.66] seconds)
  py312-djangomain: IGNORED FAIL code 1 (45.56=setup[20.94]+cmd[24.62] seconds)

And pytest ends with:

=========== 12 failed, 1540 passed, 4 skipped, 4 warnings in 22.60s ============
py312-djangomain: exit 1 (24.62 seconds)

which is why you are still working on #9233.

If you can merge #9233 then Dj5 can be supported. If not, then this PR demonstrates that Py3.12 can be supported w/o Dj5.

cclauss avatar Jan 25 '24 01:01 cclauss

If you can merge #9233 then Dj5 can be supported. If not, then this PR demonstrates that Py3.12 can be supported w/o Dj5.

Indeed, in #9233:

  py312-django42: OK (40.80=setup[15.85]+cmd[24.95] seconds)
  py312-djanggo50: OK (36.33=setup[11.82]+cmd[24.51] seconds)
  py312-djangomain: OK (45.29=setup[21.06]+cmd[24.23] seconds)

and is based on this branch, meant to be reviewed after this

math-a3k avatar Jan 25 '24 01:01 math-a3k