django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

added python 3.12 to CI

Open auvipy opened this issue 2 years ago • 10 comments

related https://github.com/encode/django-rest-framework/pull/9181

auvipy avatar Nov 05 '23 05:11 auvipy

I was going to push back and say this might be overkill, and I see our pre-commit hooks for stylelint are out-of-date again after #10719 🙈

thibaudcolas avatar Dec 22 '23 13:12 thibaudcolas

OK I will close this. It's super tedious to keep these manually up to date but I will have a PR up to update this shortly.

lb- avatar Feb 05 '24 23:02 lb-

@lb- I thought Thibaud's comment above meant that this would be useful? I'm in favour of this so I don't mind us giving it a try after we get #11595 in.

laymonage avatar Feb 06 '24 12:02 laymonage

Note that https://github.com/wagtail/wagtail/pull/11679 has been raised to further fix the manual sync of package version updates with the pre-commit config.

Looks like there was a typo (on my part) but additional inconsistencies between the latest available packages and what the 'mirror' packages have in their repo for Prettier and others.

There must be a better way to manage this, it's error prone and stops us from keeping our core code up to date due to the mirror packages also needing updating.

Hopefully I'll get a chance to understand this stuff better, but anyone with better knowledge of pre-commit can chime in with some ideas.

lb- avatar Feb 20 '24 04:02 lb-