django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

Published 20 hours ago • verified publisher icon encode

Add --version CLI option to generateschema

Open erancihan opened this issue 1 year ago • 1 comments

Description

Adds support for --version CLI argument to generateschema management command.

refs #8551

erancihan avatar Jul 11 '22 15:07 erancihan

Seems ok.

wieczorek1990 avatar Jul 30 '22 13:07 wieczorek1990

Thanks!

tomchristie avatar Sep 21 '22 12:09 tomchristie

Right, I need to be a bit tedious here. Looks like this change introduced a failing CI under Python 3.6.

See here: https://github.com/encode/django-rest-framework/actions/runs/3097673683/jobs/5014619905

I don't understand what the issue is, but it'd need to be resolved in order for us to merge this. Until then I've reverted this with #8661.

I know. Boring. 😑

tomchristie avatar Sep 21 '22 13:09 tomchristie

Well... this is awkward.

I'll take care of this later on and open a new PR.

Sorry for the inconvenience.

erancihan avatar Sep 21 '22 13:09 erancihan

Yep this is on me.

It conflicts with the version arg in the management BaseCommand. For now, I'm renaming it to api_version as it indicates the API's version that is present in the generated schema.

erancihan avatar Sep 21 '22 14:09 erancihan