django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

Properly handle OverflowError in DurationField deserialization

Open peterthomassen opened this issue 3 years ago • 4 comments

Related: https://github.com/django/django/pull/8870/files

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Properly handle OverflowError in DurationField deserialization. Solution is the same as for the corresponding Django form field.

peterthomassen avatar Jun 18 '21 13:06 peterthomassen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 25 '22 06:04 stale[bot]

I think this is still current.

peterthomassen avatar Apr 25 '22 22:04 peterthomassen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 14 '22 04:07 stale[bot]

I think this is still current.

peterthomassen avatar Jul 14 '22 11:07 peterthomassen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 22 '22 04:09 stale[bot]

I think this is still current.

peterthomassen avatar Sep 22 '22 05:09 peterthomassen

The code looks very similar to me. Which according amendments do you mean? (Would you like to change the logic, or the error message? (Number of days out of range, must be between {min_days} and {max_days}.)

peterthomassen avatar Nov 22 '22 15:11 peterthomassen

btw, having another look, it seems your code is quite right. can you please pull from master so that the CI triggers with latest changes?

auvipy avatar Nov 22 '22 15:11 auvipy

done

peterthomassen avatar Nov 22 '22 15:11 peterthomassen

thank you for your patience

auvipy avatar Nov 24 '22 11:11 auvipy