django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

Published 20 hours ago • verified publisher icon encode

Fix codecov

Open adamchainz opened this issue 4 years ago • 17 comments
trafficstars

During #7903 I realized that codecov doesn't seem to be installed correctly - it's not reporting status back on PR's, although it does have the data: https://app.codecov.io/gh/encode/django-rest-framework/compare/7903

It may need reinstalling via the GitHub Marketplace - it could have been installed with the legacy GitHub integrations system rather than as a "GitHub App".

adamchainz avatar Apr 06 '21 17:04 adamchainz

@carltongibson do you have access to this?

adamchainz avatar Apr 16 '21 16:04 adamchainz

@adamchainz. Nope. Let's call in the cavalry. 🐎 @tomchristie

carltongibson avatar Apr 16 '21 16:04 carltongibson

What do I need to do, where?

lovelydinosaur avatar Apr 21 '21 10:04 lovelydinosaur

Remove codecov from the legacy integrations in the repo settings. Login to codecov and set it up again. Then retrigger the CI run on the master branch.

adamchainz avatar Apr 21 '21 19:04 adamchainz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 30 '22 03:04 stale[bot]

Nobody is shouting at me. Let's close it. Maybe everything is fine now. 🤷‍♂️

lovelydinosaur avatar Aug 03 '22 09:08 lovelydinosaur

I still don't see codecov reports for the latest commit on the main branch?

adamchainz avatar Aug 03 '22 10:08 adamchainz

Ok, thanks @adamchainz.

I guess <mumbles grumpily>

😉

lovelydinosaur avatar Aug 03 '22 10:08 lovelydinosaur

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 01 '22 21:11 stale[bot]

should we consider https://github.com/codecov/codecov-action? Been using it in some of the projects I maintain

auvipy avatar Nov 30 '22 03:11 auvipy

I'd prefer we avoid adding tooling if possible at this point. We're likely just giving ourselves work to do.

lovelydinosaur avatar Nov 30 '22 09:11 lovelydinosaur

Latest commits already appear in codecov https://app.codecov.io/gh/encode/django-rest-framework/commits Isn't it time to close this issue?

leogregianin avatar Jan 30 '23 19:01 leogregianin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 02 '23 08:04 stale[bot]

in a recent PR it is failing to install codecov https://github.com/encode/django-rest-framework/actions/runs/4688723455/jobs/8309577776?pr=8943

pip install --upgrade codecov doesn't work anymore. so I believe we should switch to codecov gha

https://community.codecov.com/t/codecov-yanked-from-pypi-all-versions/4259/5

auvipy avatar Apr 13 '23 14:04 auvipy

codecov yanked the package: https://about.codecov.io/blog/message-regarding-the-pypi-package/

adamchainz avatar Apr 14 '23 09:04 adamchainz

yes

auvipy avatar Apr 15 '23 06:04 auvipy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 17 '23 00:09 stale[bot]