django-rest-framework
django-rest-framework copied to clipboard
SearchFilter with unaccent
Description
Implements #7727
New restriction for SearchFilter: &
Accent-insensitive search.
As this is only supported by Django's PostgreSQL backend.), no test was added (same case as the Full-text search restriction).
This uses the __unaccent
lookup, allowing for accent-insensitive searches.
Hello, what about this PR ? It's look good
can you also add a small unit test for this change?
As I explain in the PR description:
As this is only supported by Django's PostgreSQL backend, no test was added (same case as the Full-text search restriction).
I've followed what was done in the Full-text search, which is basically that there is no test.
Adding test for this would involve spinning up a PostgreSQL in order to do so, and it feels outside the scope of the intended change.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@auvipy could you take another look at this?
it should be mr. @tomchristie
Hello, what about this PR ?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hey @tomchristie , do you think you could take a look at this PR?
I will also have a look
I tried to trigger new CI but it seems the repository from which the PR was originated has been removed! so can not re open it! might do it myself in another PR