django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

SearchFilter with unaccent

Open gdvalderrama opened this issue 4 years ago • 5 comments

Description

Implements #7727

New restriction for SearchFilter: & Accent-insensitive search.

As this is only supported by Django's PostgreSQL backend.), no test was added (same case as the Full-text search restriction).

This uses the __unaccent lookup, allowing for accent-insensitive searches.

gdvalderrama avatar Feb 28 '21 17:02 gdvalderrama

Hello, what about this PR ? It's look good

Sharpek avatar Sep 04 '21 09:09 Sharpek

can you also add a small unit test for this change?

As I explain in the PR description:

As this is only supported by Django's PostgreSQL backend, no test was added (same case as the Full-text search restriction).

I've followed what was done in the Full-text search, which is basically that there is no test.

Adding test for this would involve spinning up a PostgreSQL in order to do so, and it feels outside the scope of the intended change.

gdvalderrama avatar Sep 15 '21 11:09 gdvalderrama

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '22 01:04 stale[bot]

@auvipy could you take another look at this?

gdvalderrama avatar Jun 08 '22 14:06 gdvalderrama

it should be mr. @tomchristie

auvipy avatar Jun 08 '22 14:06 auvipy

Hello, what about this PR ?

alixleger avatar Sep 21 '22 16:09 alixleger

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 23 '22 04:11 stale[bot]

Hey @tomchristie , do you think you could take a look at this PR?

gdvalderrama avatar Nov 23 '22 08:11 gdvalderrama

I will also have a look

auvipy avatar Nov 23 '22 10:11 auvipy

I tried to trigger new CI but it seems the repository from which the PR was originated has been removed! so can not re open it! might do it myself in another PR

auvipy avatar Nov 23 '22 14:11 auvipy