django-rest-framework icon indicating copy to clipboard operation
django-rest-framework copied to clipboard

Add failing test for issue #4073

Open alexcreid opened this issue 8 years ago • 4 comments

Description

Adds failing test for issue #4073.

refs #4073

alexcreid avatar Apr 27 '16 12:04 alexcreid

Yikes 👀 . Been punting on this one for a while now...

image

Aside @auvipy: Probably better to refrain from pitching in asking contributors to rebase, particularly given that the ticket's remained inactive for so long.

tomchristie avatar Apr 27 '17 16:04 tomchristie

It's not entirely clear to me what the behaviour should be where a nested serialiser has a list of errors rather than a dictionary, but it probably shouldn't be to error out.

That seems right, but we still need to settle what the appropriate response is here.

I'm going to de-milestone for now.

carltongibson avatar Oct 05 '17 11:10 carltongibson

It looks like this has been fixed at some point. Is it worth it to clean up the test case (eg, check what the expected behavior should be, instead of just not failing) and add it to the test suite?

rpkilby avatar May 20 '18 01:05 rpkilby

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 05:08 stale[bot]

It looks like this has been fixed at some point. Is it worth it to clean up the test case (eg, check what the expected behavior should be, instead of just not failing) and add it to the test suite?

that would be the right approach FMPOV. also the test seems to have lots of conflicts to resolve. I will try to investigate and try this test freshly

auvipy avatar Nov 24 '22 08:11 auvipy

that would be the right approach FMPOV. also the test seems to have lots of conflicts to resolve. I will try to investigate and try this test freshly

Why make work?

tomchristie avatar Nov 25 '22 11:11 tomchristie