databases icon indicating copy to clipboard operation
databases copied to clipboard
verified publisher icon encode

postgres: use wait_for in disconnect

Open blueyed opened this issue 6 years ago • 4 comments

This is recommended by asyncpg [1].

1: https://github.com/MagicStack/asyncpg/blob/92c2d81256a1efd8cab12c0118d74ccd1c18131b/asyncpg/pool.py#L655-L656

blueyed avatar May 07 '19 06:05 blueyed

Note that there is also a timeout for acquire, which gets used by release then also: https://github.com/MagicStack/asyncpg/blob/92c2d81256a1efd8cab12c0118d74ccd1c18131b/asyncpg/pool.py#L560-L564

blueyed avatar May 07 '19 06:05 blueyed

This is a good call yup. Presumably we also want to add the timeout to acquire right? Any thoughts about adding timeout to the API someplace, and using that value?

lovelydinosaur avatar Jun 20 '19 09:06 lovelydinosaur

@vmarkovtsev

I can take care of finishing this PR if you don't have time right now. WDYT?

Sure, please go ahead. (Sorry for the late reply, of course)

blueyed avatar Jun 04 '21 17:06 blueyed

Any progress on this?

taybin avatar Sep 08 '21 20:09 taybin