databases icon indicating copy to clipboard operation
databases copied to clipboard

SQLAlchemy 2.0

Open immanelg opened this issue 2 years ago • 18 comments

Will there be support for SQLAlchemy 2.0 or I should just use it directly?

immanelg avatar Jan 30 '23 11:01 immanelg

@madkinsz Apologies as missed this one. So as far as I could understand, its not planned to give support to SQLA 2.0?

tarsil avatar Feb 28 '23 17:02 tarsil

We need someone to maintain this package. :shrug:

Kludex avatar Feb 28 '23 19:02 Kludex

I'm not able to review a PR with that bump here...

Any of you are? @rafalp @aminalaee

Kludex avatar Feb 28 '23 21:02 Kludex

If PR's comes up that bumps SQLAlchemy support to 2.0, I'm fine with it. But I have no resources to develop one myself.

rafalp avatar Feb 28 '23 21:02 rafalp

@rafalp @Kludex no worries. Give me a few days and I will have a look and open a PR with a possible integration with SQLA 2.0

We are looking at possible backwards incompatible changes. Last time I tried a few things were changed internally within SQLA.

I don't see a reason to have forks of this package just to add SQLA 2.0 when databases is already maintained

tarsil avatar Feb 28 '23 21:02 tarsil

Cool. :+1:

Thanks. :pray:

Kludex avatar Feb 28 '23 21:02 Kludex

No problem. I have products depending of databases and having the support for 2.0 we can leverage python 3. 2.0 does not support python 2 anymore.

tarsil avatar Feb 28 '23 21:02 tarsil

any update on this issue? I'd really like to use slack-sdk which depends on databases but cannot due to this version constraint

samuela avatar Jul 15 '23 04:07 samuela

@samuela there is #539 but it has unaddressed questions and could use another contributor

zanieb avatar Jul 15 '23 04:07 zanieb

Thanks @zanieb ! I ended up finding a workaround for the time being

samuela avatar Jul 15 '23 04:07 samuela

@samuela Could you share some details of your workaround? 🙏🏻

caarmen avatar Jul 15 '23 13:07 caarmen

@caarmen they removed the package entirely as seen in f9236b3

zanieb avatar Jul 15 '23 14:07 zanieb

Can you guys tell us if you plan to add support for sqlalchemy 2.0 ?

ImEins avatar Sep 21 '23 01:09 ImEins

@ImEins there is no maintainer that is going to implement it as this time. I will review a contribution adding support.

zanieb avatar Sep 25 '23 19:09 zanieb

update?

Distortedlogic avatar Dec 08 '23 03:12 Distortedlogic

The work at https://github.com/encode/databases/pull/539 is stalled as the author is busy with other things.

zanieb avatar Dec 08 '23 14:12 zanieb

We did this. #540. Is there a timeframe for a release? @tomchristie

ansipunk avatar Feb 22 '24 11:02 ansipunk

@ansipunk there is one PR opened yesterday that requires some attention. Hopefully today or tomorrow can be merged and we can perform a release.

tarsil avatar Feb 22 '24 11:02 tarsil