Use query.params() for selectable queries

Open abetkin opened this issue 6 years ago • 5 comments

Sep 11 '19 20:09 abetkin

Heya - thanks for this! Could we get a test case and a brief explanation?

Sep 30 '19 10:09 lovelydinosaur

added a test

Sep 30 '19 17:09 abetkin

@tomchristie ping

Oct 13 '19 14:10 abetkin

Hey @abetkin thanks for fixing this, I ran into the same problem :-). FWIW I have worked around the problem by doing database.fetch_all(select_query.params(foo=1))

By the way, I notice that the test run failed simply because of file formatting in test_databases.py (perhaps just not enough new lines).

Jan 07 '20 08:01 garyd203

There's a linter failure on this pull request at the moment. Running scripts/lint would resolve this.

Apr 30 '20 09:04 lovelydinosaur