databases
databases copied to clipboard
Support for MS SQL
Hi,
I have been this library intensively for a project that I am working on. Initially we are using postgres but had to switch to Sql Server. Will there be going to be any support for this database server? Are there any workarounds for this?
Hi @ammar-azif, that's a good a question. To be honest I'm not really aware if there's an async driver/lib for MS SQL. From a brief search I can only see https://github.com/aio-libs/aioodbc as a possible driver, but it doesn't look exactly like a thing.
aioodbc is basically async wrapper around pyodbc. pyodbc is a supported solution for MS SQL. I too want support MS SQL. Looking at the interfaces it seems straight forward to implement new backend based on aioodbc. Will there be a way to add another backed?
We can runt this issue with @tomchristie, but I think it might be a good idea, it seems it implements the generic db driver, that can support not only MS SQL. Adding the new backend is relatively straightforward, there's also one pending currently - https://github.com/encode/databases/pull/124 as an example.
Supporting aioodbc seems reasonable, yup.
We've implemented aioodbc backend for our project. I'll ask my team to generate a PR so that people can benefit from it. I currently have working implementation we will create test cases and documentation so that PR can be generated.
Any updates on this? Can't wait to use this with FastAPI :)
@kesavkolla has the PR been created? If so, can you please link to it? Perhaps others watching this issue can help with getting any remaining issues with the PR resolved more quickly.
@skewty @kesavkolla The PR was created, but it was closed because they want the core support to be limited to postgresql, mysql, and sqlite.