sandstone
sandstone copied to clipboard
WRR-381: Updated docs of `aria-label` prop in PageViews, QuickGuidePanels and added `css` prop in PageViews to clean up APIs of PageViews and QuickGuidePanels
Checklist
- [x] I have read and understand the contribution guide
- [ ] A CHANGELOG entry is included
- [x] At least one test case is included for this feature or bug fix
- [x] Documentation was added or is not needed
- [ ] This is an API breaking change
Issue Resolved / Feature Added
- In PageViews and QuickGuidePanels,
aria-label
prop needs to have more proper documentation. -> PageView does not needaria-label
prop because it will be set in PageViews.Page and QuickGuidePanels needs to havearia-label
as private prop because it will also be set in QuickGuidePanels.Panel. - Add
css
prop in PageViews to allow customizing the component - Make
onClose
andcloseButtonAriaLabel
props of PageViews to be public.
Resolution
Remove unnecessary aria-label
prop in PageViews and add private aria-label
prop documentation in QuickGuidePanels.
Add aria-prop
documentation in PageViews.Page and QuickGuidePanels.Panel.
Make onClose
and closeButtonAriaLabel
prop in PageViews to be public
Add css
prop in PageViews to allow customizing the component instead of using navigationButtonOffset
prop.
Additional Considerations
In QuickGuidePanels and WizardPanels, I fixed the typo PrevButton
-> prevButton
Links
WRR-381