sandstone icon indicating copy to clipboard operation
sandstone copied to clipboard

Published 20 hours ago • verified publisher icon enactjs

WRQ-19324: Remove findDOMNode in Dropdown and ContextualPopupDecorator

Open juwonjeong opened this issue 9 months ago • 1 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

As findDOMNode will be removed in React 19, replace/remove findDOMNode in sandstone code.

Resolution

Remove findDOMNode in contextualPopupDecorator and added a wrapper div element. Remove findDOMNode in DropdownList. Because findDOMNode used to configure enterTo to selected item(defualt-element). However, the logic(https://github.com/enactjs/sandstone/commit/4249b22035e957d1fe0f70cb297f5c23511ff195) already exists that spot the selected item without enterTo configuration.

Additional Considerations

Links

WRQ-19324

Comments

juwonjeong avatar May 13 '24 01:05 juwonjeong