sandstone
sandstone copied to clipboard
WRQ-8429: Fixed back button not to work when disabled is set to true on input component
Checklist
- [X] I have read and understand the contribution guide
- [x] A CHANGELOG entry is included
- [ ] At least one test case is included for this feature or bug fix
- [X] Documentation was added or is not needed
- [ ] This is an API breaking change
Issue Resolved / Feature Added
I have solved an issue where the back button does not work when you change disabled to true after entering the input popup from the input sampler.
Resolution
I modified the popup to close when disabled is true while the popup is open. This is the same behavior as dropdown.
Additional Considerations
I thought of three ways to solve the issue. That is, making the back button work independently of the popup, disabling the back button, and closing the popup.
Links
WRQ-8429
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.55%. Comparing base (
0fb0222
) to head (219eeda
).
Additional details and impacted files
@@ Coverage Diff @@
## develop #1600 +/- ##
========================================
Coverage 81.55% 81.55%
========================================
Files 148 148
Lines 6673 6673
Branches 1986 1986
========================================
Hits 5442 5442
Misses 938 938
Partials 293 293
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
And, please solve the conflicts too.