sandstone
sandstone copied to clipboard
WRQ-8004: Focus on Body Text partially in Scroller with audio guidance ON
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Checklist
- [x] I have read and understand the contribution guide
- [ ] A CHANGELOG entry is included
- [ ] At least one test case is included for this feature or bug fix
- [x] Documentation was added or is not needed
- [ ] This is an API breaking change
Issue Resolved / Feature Added
For accessibility, we need a scroller sample that changes its behavior depending on the value of audio guidance.
- When audio guidance is off, scroll thumb or whole body text should be focused and the focus can be moved between them by Enter key.
- When audio guidance is on, body text should be splited into several parts and each part should get focus as a spottable element. Using spottable, focus can be moved in the body text area by up/down key and scroll moves following focus.
Resolution
Changed the scroller sample in qa-a11y to partially focus on body text when audio guidance is on.
- get the value of audio guidance from settings
- focusableScrollbar option is true/'byEnter' when audio guidance is on/off.
- apply/not apply spottable to each part of body text when auido guidance is on/off.
Additional Considerations
Links
WRQ-8004
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2b2a3c6
) 81.24% compared to head (5f74380
) 81.24%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1556 +/- ##
========================================
Coverage 81.24% 81.24%
========================================
Files 141 141
Lines 6499 6499
Branches 1921 1921
========================================
Hits 5280 5280
Misses 932 932
Partials 287 287
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let's move the ScrollWithBodyTextFocus to Scroller by adding one more Toggle Button which enables and disables audioGuidance.
To not affect original Scroller qa-a11y samples, ScrollView will return the original div with Foo, Bar when audioGuidance is off
. And returns <Container> that wrapped Spottable divs when audioGuidance is `on.
LGTM but this requirement is dropped as of now. I won't close this PR in case the requirement will be live later.