sandstone icon indicating copy to clipboard operation
sandstone copied to clipboard

WRQ-3732: Fixed Scroller with editable prop to complete editing when focus is leaving by 5-way key on pointer mode

Open 0x64 opened this issue 1 year ago • 1 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

In all conditions below met, focus is moving out of an editable scroller but editing mode is not completed and a selected item is kept selected;

  • The editable scroller is editing mode
  • An item is selected
  • Pointer mode
  • No item or buttons are focused by pointer
  • A user press 'enter' ('OK')

Resolution

Fixed an editable scroller logic to complete editing when the condition is detected.

Additional Considerations

Links

WRQ-3732

Comments

0x64 avatar Nov 30 '23 04:11 0x64

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e803163) 80.40% compared to head (1e9c409) 80.40%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1523   +/-   ##
========================================
  Coverage    80.40%   80.40%           
========================================
  Files          141      141           
  Lines         6488     6488           
  Branches      1917     1917           
========================================
  Hits          5217     5217           
  Misses         969      969           
  Partials       302      302           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 04:11 codecov[bot]