sandstone icon indicating copy to clipboard operation
sandstone copied to clipboard

WRN-12925: Remove non-latin font rules from less files

Open juwonjeong opened this issue 2 years ago • 1 comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])

Checklist

  • [x] I have read and understand the contribution guide
  • [x] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

After refactoring, https://github.com/enactjs/enact/pull/2465 all language glyphs render in ther designated font regardless of the current locale. Css rules that reduce font style differences between fonts are no longer needed.

Resolution

Remove css rules in which the selector start with .enact-locale-non-latin from .less files

Additional Considerations

Links

WRN-12925

Comments

juwonjeong avatar Mar 11 '22 08:03 juwonjeong

Codecov Report

Merging #1190 (83ec000) into develop (6549edd) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1190   +/-   ##
========================================
  Coverage    56.54%   56.54%           
========================================
  Files          135      135           
  Lines         6230     6230           
  Branches      1770     1770           
========================================
  Hits          3523     3523           
  Misses        2107     2107           
  Partials       600      600           
Impacted Files Coverage Δ
ThemeDecorator/ThemeDecorator.js 80.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6549edd...83ec000. Read the comment docs.

codecov[bot] avatar Mar 11 '22 08:03 codecov[bot]