enact
enact copied to clipboard
WRQ-15921: Fix spotlight.disableSelector to set selectorDisabled to false
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Checklist
- [x] I have read and understand the contribution guide
- [ ] A CHANGELOG entry is included
- [ ] At least one test case is included for this feature or bug fix
- [x] Documentation was added or is not needed
- [ ] This is an API breaking change
Issue Resolved / Feature Added
Resolution
enableSelector
needs to set selectorDisabled to true and disableSelector
needs to set selectorDisabled to false.
Additional Considerations
Links
WRQ-15921
Comments
Codecov Report
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 82.51%. Comparing base (
67b7156
) to head (9890107
).
Files | Patch % | Lines |
---|---|---|
packages/spotlight/src/spotlight.js | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #3232 +/- ##
========================================
Coverage 82.51% 82.51%
========================================
Files 157 157
Lines 7245 7245
Branches 1917 1917
========================================
Hits 5978 5978
Misses 995 995
Partials 272 272
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note: this PR fixes a bug from #703
💯
Shouldn't we add a change log for this?