enact
enact copied to clipboard
WRQ-11247: Added fontScale prop for large text mode scale values
Checklist
- [x] I have read and understand the contribution guide
- [ ] A CHANGELOG entry is included
- [ ] At least one test case is included for this feature or bug fix
- [x] Documentation was added or is not needed
- [ ] This is an API breaking change
Issue Resolved / Feature Added
There is a requirement for large text mode for a11y. I have modified the app (including sampler) to review the screen when large text is applied.
Resolution
Modified to update the base font size when the fontScale prop changes.
Additional Considerations
Links
WRQ-11247
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Codecov Report
Attention: Patch coverage is 66.66667%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 82.34%. Comparing base (
18333f7
) to head (7d442c5
).
Files | Patch % | Lines |
---|---|---|
packages/ui/resolution/ResolutionDecorator.js | 60.00% | 3 Missing and 1 partial :warning: |
packages/ui/resolution/resolution.js | 75.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #3217 +/- ##
===========================================
- Coverage 82.36% 82.34% -0.03%
===========================================
Files 156 156
Lines 7209 7221 +12
Branches 1907 1908 +1
===========================================
+ Hits 5938 5946 +8
- Misses 999 1002 +3
- Partials 272 273 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mmyelyn, font scale does not work with http://SERVERIP:8080/?path=/story/about-a-tour-of-sampler--a-tour-of-sampler&globals=font+scale:1.6. Could you please check it?
@mmyelyn, font scale does not work with http://SERVERIP:8080/?path=/story/about-a-tour-of-sampler--a-tour-of-sampler&globals=font+scale:1.6. Could you please check it?
This is because fontScale was not passed when updating the base font in init. In the process of fixing, i modified fontScale to be managed as an internal resolution variable. So, the fontScale parameter that was passed to the calculate function has been deleted.
I think it is better to apply 4b93d18861378ed94dfeb9a6febd4c9be9fb8f3f commit to not change the original init function, but I need the merger's opinion.