enact icon indicating copy to clipboard operation
enact copied to clipboard

WRQ-6220: Fixed `spotlight` navigation from the focused element clipped by an overflow container

Open 0x64 opened this issue 1 year ago • 1 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [x] A CHANGELOG entry is included
  • [x] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

Spotlight cannot choose the next focus target if the currently focused node is partially visible as clipped by an overflow container. Note that a clipped node within an overflow container can be a navigable target.

Resolution

Updated a navigation logic to count only a visible part if the currently focused node is partially visible and its closest container is an overflow container.

Additional Considerations

Links

WRQ-6220

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])

0x64 avatar Feb 20 '24 01:02 0x64

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.39%. Comparing base (d89daae) to head (f2f155d). Report is 1 commits behind head on develop.

Files Patch % Lines
packages/spotlight/src/target.js 83.33% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3210      +/-   ##
===========================================
+ Coverage    82.29%   82.39%   +0.10%     
===========================================
  Files          155      155              
  Lines         7149     7241      +92     
  Branches      1885     1921      +36     
===========================================
+ Hits          5883     5966      +83     
- Misses         995     1003       +8     
- Partials       271      272       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 01:02 codecov[bot]