enact icon indicating copy to clipboard operation
enact copied to clipboard

WRQ-3732: Notify focus moving by key from pointer mode internally

Open 0x64 opened this issue 1 year ago • 1 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

When focus is entering to or leaving from a container by 5-way key input on 5-way mode, Spotlight notify this situation internally so that related features works properly. But there is no notification on pointer mode at the same situation.

Resolution

Update internal logic to notify the situation on pointer mode just like on 5-way mode.

Additional Considerations

Links

WRQ-3732

Comments

0x64 avatar Nov 30 '23 04:11 0x64

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6becfeb) 82.22% compared to head (4533dbe) 82.16%. Report is 1 commits behind head on develop.

Files Patch % Lines
packages/spotlight/src/spotlight.js 0.00% 6 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
- Coverage    82.22%   82.16%   -0.06%     
===========================================
  Files          155      155              
  Lines         7149     7154       +5     
  Branches      1885     1885              
===========================================
  Hits          5878     5878              
- Misses         998     1003       +5     
  Partials       273      273              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 04:11 codecov[bot]