enact icon indicating copy to clipboard operation
enact copied to clipboard

WRN-17866: POC for item reordering in VirtualList

Open 0x64 opened this issue 2 years ago • 1 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [x] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

POC for item reordering in VirtualList

Resolution

Added relocation logic

Additional Considerations

Links

WRN-17866, WRN-16706 (#3016) enactjs/sandstone/pull/1189

Comments

0x64 avatar Mar 10 '22 10:03 0x64

Codecov Report

Merging #3027 (bde5f5b) into develop (33c4a1b) will decrease coverage by 5.03%. The diff coverage is 11.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3027      +/-   ##
===========================================
- Coverage    48.57%   43.53%   -5.04%     
===========================================
  Files          171      163       -8     
  Lines         9455     9433      -22     
  Branches      2359     2339      -20     
===========================================
- Hits          4593     4107     -486     
- Misses        3782     4105     +323     
- Partials      1080     1221     +141     
Impacted Files Coverage Δ
packages/ui/VirtualList/VirtualList.js 76.47% <ø> (ø)
packages/ui/useScroll/useScroll.js 12.55% <ø> (-28.21%) :arrow_down:
packages/ui/VirtualList/VirtualListBasic.js 14.67% <11.51%> (-46.23%) :arrow_down:
packages/ui/useScroll/utilEvent.js 5.55% <0.00%> (-77.78%) :arrow_down:
packages/ui/useScroll/Scrollbar.js 17.64% <0.00%> (-52.95%) :arrow_down:
packages/ui/useScroll/ScrollbarTrack.js 57.14% <0.00%> (-42.86%) :arrow_down:
packages/ui/useScroll/ScrollAnimator.js 17.85% <0.00%> (-8.93%) :arrow_down:
packages/webos/speech/readAlert.js
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33c4a1b...bde5f5b. Read the comment docs.

codecov[bot] avatar Mar 10 '22 10:03 codecov[bot]