enact icon indicating copy to clipboard operation
enact copied to clipboard

Update a list item style for horizontal lists

Open 0x64 opened this issue 5 years ago • 2 comments

Checklist

  • [x] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [ ] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

A virtual list sets a CSS class for its item internally and the CSS covers a vertical list only.

Resolution

Update CSS to cover an item of a horizontal list also.

Additional Considerations

A list sets a selector of two CSS classes for an item currently and it blocks an app side single CSS class for an item by higher specificity. We are using modular CSS now, so we actually don't need to put such a complex CSS selector for a list item. To make apps easy to override item sizes, needs to be flattened.

Links

PLAT-86356

Comments

0x64 avatar Dec 10 '19 07:12 0x64

Codecov Report

Merging #2659 into develop will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2659      +/-   ##
===========================================
- Coverage       47%   46.99%   -0.01%     
===========================================
  Files          263      263              
  Lines        11584    11581       -3     
  Branches      2771     2769       -2     
===========================================
- Hits          5445     5443       -2     
  Misses        4557     4557              
+ Partials      1582     1581       -1
Impacted Files Coverage Δ
packages/ui/VirtualList/VirtualListBase.js 60.51% <100%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91bb578...d9d8efc. Read the comment docs.

codecov[bot] avatar Dec 11 '19 09:12 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 28 '21 08:10 CLAassistant