enact icon indicating copy to clipboard operation
enact copied to clipboard

ENYO-5755: Add voice control attribute extractor

Open changgilee opened this issue 6 years ago • 2 comments

Checklist

  • [x] I have read and understand the contribution guide

  • [ ] A CHANGELOG entry is included

  • [x] At least one test case is included for this feature or bug fix

  • [ ] Documentation was added or is not needed

  • [x] This is an API breaking change

Issue Resolved / Feature Added

In current status, propType should be added in each moonstone components when additional voice control attribute need

Resolution

Add extractor function for pre-check and delegate voiceProps to sub components.

Additional Considerations

Links

ENYO-5755

Comments

Enact-DCO-1.0-Signed-off-by: Changgi Lee [email protected]

changgilee avatar Dec 26 '18 05:12 changgilee

With these changes, all the information related to data-voice-* props is hidden and also removed from the documentation. Can you add props back for the docs?

Also, please resolve merge conflicts as well. Thanks

viodragon2 avatar Mar 20 '19 00:03 viodragon2

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 28 '21 08:10 CLAassistant