Eric Walker comments

Results 36 comments of


                                            Eric Walker

Use Rust's built-in support for integration tests

Having trouble tracking down this [test input](https://github.com/jaytaph/gosub-browser/blob/558e3dc6843c2572916c19eec459d0d5679f64de/src/bin/tokenizer_test.rs#L56). Do you have this in your personal working directory and ignored by Git?

Use Rust's built-in support for integration tests

Ah, gotcha. I wasn't aware of the `html5lib-tests` test suite. Whether you emit a usage warning or not will depend on whether you attempt to move this to a Rust...

Use Rust's built-in support for integration tests

> Does this mean we have to keep an updated version of html5lib tests in our repo It could be updated periodically, whenever someone thinks to check. But between updates,...

Use Rust's built-in support for integration tests

Submitted https://github.com/jaytaph/gosub-browser/pull/27

Use Rust's built-in support for integration tests

@jaytaph should I migrate `src/bin/parser_test.rs` over to the new integration test pattern, or hold off for you to assess whether you like it first?

Use Rust's built-in support for integration tests

Ok, that works.