emveepee

> Is the intent to use this in ${ADDON_BUILD}/${PKG_ADDON_ID}/lib.private and then add the LD_LIBRARY_PATH in packages/addons/service/nextpvr/source/bin/nextpvr.start or something like how we included the icu libraries in dotnet? Basically my future...

> I can't see where the nextpvr-bin is included in the LD_LIBRARY_PATH. There are a couple addons that have LD_LIBRARY_PATH set in them post the lib.private cleanup - example being...

> I had a look at this - and probably the right way to go is include this `hdhomerun_config` binary in the addon - but I would suggest it not...

> would like to see the nextpvr commit included in the PR. Would like to see the .so file located in a location that was not bin or lib -...

@heitbaum what am I doing wrong the zip file that gets created for service.nextpvr has hdhomerun_config +x but when installed they lose the attribute. ``` ls /storage/.kodi/addons/service.nextpvr/local/ -lt total 7708...

> Kodi unzip does carry the execute bit across. Have a look here. > When I unzip the same zip manually on the same box it is ok so the...

Testing with it copied twice It is odd, everything in bin is being marked +x Here is what the source zip has ``` CoreELEC1:/tmp # ls -lt service.nextpvr/bin/ total 76...

> Your testing is correct. > > * The zip files are correct. > * Kodi unzip doesn’t honour the x > * LE adds x to all /bin/ I...

> Looking good. All looks self contained 👍. Ready for merging? No I still need to add the release version for v7 plus I also have to meet a request...

@heitbaum I have added comskip and also the updated to the new version on NextPVR 7.0.0. I will squash the two commits after you review the changes. One concern I...