cleanrip icon indicating copy to clipboard operation
cleanrip copied to clipboard

create new folder per dump

Open schicho opened this issue 4 years ago • 4 comments

Reduces the clutter in the root directory and also makes it easier to find the corresponding files.

schicho avatar Aug 21 '20 10:08 schicho

If there are better naming suggestions - I bet there are, please let me know!

My idea behind adding timestamps was so that when you aborted a dump and started it again the folder creation would fail. You technically could check that and just use the old folder, but other possibly corrupted files would still be in there. So I went with completely new folder per dump.

schicho avatar Aug 22 '20 11:08 schicho

I like this but can we make it an option "Create directory per dump [Yes/No]"? I'm happy for it to always come under cleanrip-dumps or whatever though, dumping to the root was never a good idea 😂

emukidid avatar Oct 26 '20 06:10 emukidid

If I implement an option for it, it would require a lot of checks in the several dumping/writing functions (dump_bca, dump_game, dump_info) to control wether to write to /cleanrip-dumps/ or /cleanrip-dumps/gamename/ .

That will result in a lot of duplication and probably does not make the code very readable.

You decide. I can implement it, but I don't think it's great that way.

As the middle way, I can also just change it to use /cleanrip-dumps/ , which is still an improvment over dumping straight into the root directory.

schicho avatar Oct 26 '20 23:10 schicho

Can this still be implemented??

MasterLuma avatar Jul 27 '22 01:07 MasterLuma