EmuFlight icon indicating copy to clipboard operation
EmuFlight copied to clipboard

Vbat precision increment

Open tylercorleone opened this issue 4 years ago • 13 comments

This PR fundamentally contains the cherry-pick of this PR: https://github.com/betaflight/betaflight/pull/7255/commits plus a couple of changes needed because of conflicts.

tylercorleone avatar Apr 09 '20 13:04 tylercorleone

@tylercorleone thanks!

gretel avatar Apr 09 '20 19:04 gretel

it's working fine 🥇

gretel avatar Apr 10 '20 01:04 gretel

@Quick-Flash approvals are not intended to block merges, please stop that or do not review

gretel avatar Apr 10 '20 23:04 gretel

It's a pleasure for me to contribute :) guys, you decide when to merge, I enjoy making these changes, but I don't know the project's roadmap, so manage them as you see fit!

tylercorleone avatar Apr 11 '20 14:04 tylercorleone

i think the point was to not approve, nor request change. i've created a label "On-Hold" and applied it. i'm open to renaming or not using, but it's an option.

nerdCopter avatar Apr 13 '20 15:04 nerdCopter

the root cause is the configurator being broken and not getting maintained. there is no actual relation but some people trying to manage "user experience" in a strange way. flight code is flight code and this is not the configurator repository. besides, this project should have had a roadmap ages ago. so people can actually agree on something instead of acting in their own preference.

gretel avatar Apr 13 '20 19:04 gretel

@tylercorleone wait i commented on the wrong pr.. branch :) i'm getting this set vbat_comp_ref = 84 issue using the code commited here.

gretel avatar Apr 15 '20 23:04 gretel

@tylercorleone wait i commented on the wrong pr.. branch :) i'm getting this using the code commited here.

Hi @gretel I just tried a fresh build from this branch, flashing with full erase and I obtain this (no diffs uploaded):

get vbat_comp_ref

vbat_comp_ref = 370 rateprofile 0 Allowed range: 100 - 500

tylercorleone avatar Apr 16 '20 08:04 tylercorleone

@tylercorleone it was flying this code for long now.. can you check if it still works fine one recent master? regards

gretel avatar Jun 13 '20 14:06 gretel

@nerdCopter if you can do the gui updates then we can get this merged.

Quick-Flash avatar Apr 26 '21 16:04 Quick-Flash

yeah, i've created a local branch days ago and tried to merge this (massive conflicts). i need a big chunk of time to get this + gui up to par.

nerdCopter avatar Apr 26 '21 19:04 nerdCopter

yeah, i've created a local branch days ago and tried to merge this (massive conflicts). i need a big chunk of time to get this + gui up to par.

Any update here?

Quick-Flash avatar Jun 02 '21 23:06 Quick-Flash

Any update here?

zero effort since.

nerdCopter avatar Jun 03 '21 15:06 nerdCopter