EmuFlight
EmuFlight copied to clipboard
Vbat precision increment
This PR fundamentally contains the cherry-pick of this PR: https://github.com/betaflight/betaflight/pull/7255/commits plus a couple of changes needed because of conflicts.
@tylercorleone thanks!
it's working fine 🥇
@Quick-Flash approvals are not intended to block merges, please stop that or do not review
It's a pleasure for me to contribute :) guys, you decide when to merge, I enjoy making these changes, but I don't know the project's roadmap, so manage them as you see fit!
i think the point was to not approve, nor request change. i've created a label "On-Hold" and applied it. i'm open to renaming or not using, but it's an option.
the root cause is the configurator being broken and not getting maintained. there is no actual relation but some people trying to manage "user experience" in a strange way. flight code is flight code and this is not the configurator repository. besides, this project should have had a roadmap ages ago. so people can actually agree on something instead of acting in their own preference.
@tylercorleone wait i commented on the wrong pr.. branch :) i'm getting this set vbat_comp_ref = 84
issue using the code commited here.
@tylercorleone wait i commented on the wrong pr.. branch :) i'm getting this using the code commited here.
Hi @gretel I just tried a fresh build from this branch, flashing with full erase and I obtain this (no diffs uploaded):
get vbat_comp_ref
vbat_comp_ref = 370 rateprofile 0 Allowed range: 100 - 500
@tylercorleone it was flying this code for long now.. can you check if it still works fine one recent master
? regards
@nerdCopter if you can do the gui updates then we can get this merged.
yeah, i've created a local branch days ago and tried to merge this (massive conflicts). i need a big chunk of time to get this + gui up to par.
yeah, i've created a local branch days ago and tried to merge this (massive conflicts). i need a big chunk of time to get this + gui up to par.
Any update here?
Any update here?
zero effort since.