SlackPirate icon indicating copy to clipboard operation
SlackPirate copied to clipboard

Efficient credentials scanning

Open kmmanoj opened this issue 5 years ago • 1 comments

This PR solves issue #46

What does this solve?

  • Data loss - the regex filtering sometimes does not extract the right word. In this fix, it does not regex filter from the text.
  • Moreover, it uses a more generalised search query.

How does it get? It looks out sensitive words and gets the text. The text is put as it is in the file

kmmanoj avatar Feb 22 '20 08:02 kmmanoj

Thanks for the PR @kmmanoj - apologies it's taken this long to actually look at it. I'm going to see if I can further improve this as it wasn't catching some passwords in some tests of mine for some reason.

emtunc avatar Mar 27 '20 00:03 emtunc