Steve Boyd

Results 44 comments of Steve Boyd

@sabina-talipova I've done an initial peer review on the PRs only looking at code changes, I haven't tested locally. I've also bumped the size on this card from medium to...

Good investigation Yeah seems like we should not merge this just now given potential performance regressions on every page edit load just to make more accurate save/publish buttons. I always...

## Recommendation: - Either swap out redux-form to react-hook-form, OR - Just keep using redux-form for a while longer as it still works for us and isn't technically broken -...

This also affects 4.13 Issue is that the react field cannot handle the thousands separately, e.g. 999 is fine while 1,000 is not You can also workaround this by simply...

> the issue remains when using inline editing That's not the experience I had in both CMS 4 and 5 - `->setHTML5(true)` resolved the issue for me

Sounds like a bug could you please link your pull-request

Thanks for reporting this Have you tried removing the second minus to see what happens?

@purplespider thanks for your feedback on https://forum.silverstripe.org/t/announcing-silverstripe-cms-recipe-5-0-0-beta1/6410 - I've raised this new issue to resolve how TinyMCE looks. Regarding the tooltips - they seem to work at my end, though...

I think I'd be more in favour of a `jsonResponse($data): HTTPRequest` style method rather creating than a `JSONReponse class`. Adding a class means there's now an extra types of thing...