Identity comparison for air block.

[KrystilizeNevaDies]

trafficstars

Comparing with Block.AIR should be Block.AIR.compare(block), not an identity comparison.

[emortaldev]

Does it matter? I thought it only mattered for blocks with data like rotations and stuff

[KrystilizeNevaDies]

An air block with a different block handler or different nbt would not equal. Actually Block.withProperties("") would even be a different object

[mworzala]

those should be different in this case. Otherwise the nbt/handler will be removed

[KrystilizeNevaDies]

Even with the exact same nbt, block handler, and properties, as long as it's a different block object, they will not be equal

[mworzala]

Block#compare uses ID by default, meaning two air blocks with different handler or NBT will be considered the same. Then the RLE being used on air here will remove the handler and NBT. You can use compare, but also need to check handler and nbt.

[KrystilizeNevaDies]

@mworzala wouldn't you be ignoring block handlers? I don't see how you could serialise them?

[mworzala]

you should serialize the nbt + the name of the block handler if present.

This does bring up a different problem with this implementation though, it A: assumes that there is a block handler if there is NBT on a block and B: uses the block name as the block handler. It needs to save the block handler separately if present.