OutRun2006Tweaks icon indicating copy to clipboard operation
OutRun2006Tweaks copied to clipboard

Incorrect animation speed on Heart Attack Mode

Open Sonic-TV opened this issue 1 year ago • 6 comments

Tested on C2C Mode, all 3 characters.

Sonic-TV avatar Jul 10 '24 15:07 Sonic-TV

Are you trying to run it above 60FPS?

Tenome avatar Jul 10 '24 17:07 Tenome

yes.

Sonic-TV avatar Jul 10 '24 17:07 Sonic-TV

That's probably the issue then. https://github.com/emoose/OutRun2006Tweaks/issues/31

Tenome avatar Jul 10 '24 17:07 Tenome

Which anim has the wrong speed for you? The character models themselves or is it something with the sprites?

emoose avatar Jul 10 '24 20:07 emoose

sprites. Including mission prompts and rank display.

Sonic-TV avatar Jul 10 '24 23:07 Sonic-TV

note: after testing, only C2C heart attack got affected,this doesn't affect standard and 2sp mode.

Sonic-TV avatar Aug 10 '24 12:08 Sonic-TV

New problem: when I disable the framerate lock, the cars flash too fast in mission "Keep passing cars!".

https://github.com/user-attachments/assets/39009c5a-6f8d-4e00-a22f-c25447313db9

Sonic-TV avatar Sep 17 '24 17:09 Sonic-TV

Flash speed should be fixed in https://github.com/emoose/OutRun2006Tweaks/commit/e3fe8f5a4832a856c88ee2dab882e49fc38a3213 / https://github.com/emoose/OutRun2006Tweaks/actions/runs/10916033019, let me know if that helps.

E: maybe this could be improved later on though, the flashing works by adding 0.10471975 to that sin_param var every frame, this just forces it to skip adding on above-60 frames, changing it so the amount it adds scales based on FPS instead would probably be smoother.

emoose avatar Sep 18 '24 05:09 emoose

Feels like this will be a whack-a-mole of patching animations that are tied to FPS lol. First water, now this.

Tenome avatar Sep 18 '24 06:09 Tenome

I haven't tested C2C HA mode either. This may requires tons of work...

Sonic-TV avatar Sep 18 '24 07:09 Sonic-TV

Flash speed should be fixed in e3fe8f5 / https://github.com/emoose/OutRun2006Tweaks/actions/runs/10916033019, let me know if that helps.

E: maybe this could be improved later on though, the flashing works by adding 0.10471975 to that sin_param var every frame, this just forces it to skip adding on above-60 frames, changing it so the amount it adds scales based on FPS instead would probably be smoother.

tested, and it works on standard mode. But it's a completely mess on C2C HA mode if you don't set a framerate limit to it. (Notice the "Hit the Cars" mission.)

Sonic-TV avatar Sep 18 '24 14:09 Sonic-TV

Ah yeah looks like the player car color change is handled in a different spot instead, it really is whack a mole with these >.>

Should be fixed in https://github.com/emoose/OutRun2006Tweaks/commit/276a5cbe1fa7c2248ac1bfe30a057d00cd8ff90c / https://github.com/emoose/OutRun2006Tweaks/actions/runs/10924836990, there's still an issue with UI for C2C HA getting all stretched and wrong speed when at 1000+ FPS though, not sure why that happens there but works fine in other modes.

emoose avatar Sep 18 '24 15:09 emoose

Ah yeah looks like the player car color change is handled in a different spot instead, it really is whack a mole with these >.>

Should be fixed in 276a5cb / https://github.com/emoose/OutRun2006Tweaks/actions/runs/10924836990, there's still an issue with UI for C2C HA getting all stretched and wrong speed when at 1000+ FPS though, not sure why that happens there but works fine in other modes.

yea just tried and it works, but all of the rest excl. stage total rank are messed up... weird...

Sonic-TV avatar Sep 18 '24 15:09 Sonic-TV

OR mode "PASS!!", "STAGECLEAR" messages are moving too fast when set fps to unlimited.

Sonic-TV avatar Sep 23 '24 17:09 Sonic-TV

All of the animation problems have been solved now after some testing. This issue may be opened if new animation-related problems are present.

Sonic-TV avatar Oct 01 '24 06:10 Sonic-TV