brackets-emmet New line indentation off by one space or tab

New line indentation off by one space or tab

Open timseverien opened this issue 9 years ago • 15 comments

Bug

To reproduce

Take any document
Create an element with one or more children
Set cursor at the end of parent element
Press [enter] to create a new line
See how the indentation is short exactly one space (or tab)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Sep 17 '14 08:09 timseverien

Oct 08 '14 00:10 nunoarruda

Did either of you find anything to stop/fix this?

Jan 26 '15 06:01 equinox

For curiosity tried to debug the problem and found it's source:

At line 49 from brackets-emmet/node_modules/emmet/lib/action/linebreaks.js file the function insertLineBreakAction() has a loop that counts the line padding for the new indented line:

for (var i = lineRange.end + 1, ch; i < len; i++) {
    ch = content.charAt(i);
    if (ch == ' ' || ch == '\t')
        nextPadding += ch;
    else
        break;
}

Adding 1 to the "i" makes it jump a character over. This makes the auto indent be missed by a space or tab.

This is bug comes from the emmet core library itself. To solve it just remove the "+ 1" from the for loop assignment.

I'm not fixing it because i'm new to github and don't know well how to use it yet... :confused:

Feb 02 '15 22:02 Miguel-Rodrigues

Feb 10 '15 14:02 jeffshaver

May 07 '15 12:05 lixiaoyan

+1 I'm having this issue still. Place cursor at end of line that is an open div with a class name set. press enter, it will only indent 3 spaces. Press up, end, enter and it will indent 2. Repeat and it will indent 1. Then again and it will indent 0. Needs fixed!