MoonGen icon indicating copy to clipboard operation
MoonGen copied to clipboard

This fixes a segmentation fault if the pcap is too small.

Open sn0cr opened this issue 7 years ago • 5 comments

Hi @emmericp,

during my testing with small pcaps (containing only the TCP handshake) I found that the replay-pcap example crashes Moongen with a SegFault. With this change this should not happen (at least this is the simplest change to mitigate it)

sn0cr avatar Aug 17 '18 21:08 sn0cr

Hmm, the root cause of this is something else; __ipairs shouldn't return nil buffers.

emmericp avatar Aug 17 '18 21:08 emmericp

Can you send me an example pcap to reproduce this? Or put it in your home directory on one of the persistent servers

emmericp avatar Aug 17 '18 21:08 emmericp

Possibly related #240

holzingk avatar Apr 04 '19 09:04 holzingk

I can confirm that this patch/PR is required for replaying a pcap trace in rate limiting mode to work. Not sure about the size part tho. The trace I am using is 100M.

shuwens avatar Jul 01 '19 19:07 shuwens

I sent @emmericp an example pcap via email. Hope it gets fixed soon.

holzingk avatar Jul 31 '19 15:07 holzingk