igir icon indicating copy to clipboard operation
igir copied to clipboard

Published 20 hours ago • verified publisher icon emmercm

Refactor: ES-DE Name Wrong

Open maxexcloo opened this issue 10 months ago • 3 comments

Apologies for this one, I realize you pointed this out before. It turns out that ES-DE is not EmulationStation, I think it would make sense to rename EmulationStation to ES-DE in the code to make this accurate.

maxexcloo avatar Apr 05 '24 06:04 maxexcloo

:test_tube: Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:maxexcloo/igir#patch-1" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

github-actions[bot] avatar Apr 05 '24 07:04 github-actions[bot]

@maxexcloo do the two have different folder structures? Admittedly, I've never used any version of EmulationStation. I couldn't find reliable information about how the two might diverge.

emmercm avatar Apr 06 '24 21:04 emmercm

EmulationStation hasn’t been updated since 2015 so I’d say ES-DE would be a more accurate name - I think folder structures may differ very slightly (will check when I’m back at my desk).

maxexcloo avatar Apr 06 '24 22:04 maxexcloo

:lock: Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

github-actions[bot] avatar Sep 30 '24 02:09 github-actions[bot]