Emmanuel Gomez
Emmanuel Gomez
Hi @CookieCookson, how's it going? Have you had a chance to review this? Is there anything I can do to help?
To be clear, I wasn’t expecting you to investigate the test I introduced! I imagined merging the flaky test and hitting retry on CI if it fails there. Not the...
@CookieCookson alright, I resolved the flake. In lieu of mocking, stubbing, or adding a dependency (e.g., `.toBeOneOf()` from https://github.com/jest-community/jest-extended), I took a ... creative ... approach. Viz., I flipped actual...
I'd be delighted to see this land soon. Please let me know if there's anything else you'd like to see before merging this.
@CookieCookson thanks for looking again. I looked back at the last PR ("support Cmi5 from the backend"), and I think you're referring to [this comment](https://github.com/xapijs/cmi5/pull/266#issuecomment-2321126209), and yet ...I'm confused 🤔....
I went ahead and close #265; all done there! Thanks for your encouragement and review. And again, thanks for publishing this project.