Marc-André Charpentier
Marc-André Charpentier
Sorry to bother you again, @ybiquitous, but since the `getFormatterFunction()` function is only called inside `standalone` I can't figure out an effective way of telling if stylelint is being called...
@ybiquitous, I was waiting for your input to go ahead here. Do you prefer I complete the tests and everything before having on a look on the feature implementation?
Perfect, that's how I see it too. I'll go ahead with the tests and docs. A good day to you, @ybiquitous.
Hello, @ybiquitous! Tests and doc added. Still got problems with the snapshots though. I've run this but to no avail: ```sh npm run test --ignore-scripts -- --updateSnapshot system-tests/ ``` Any...
> To make the first step easier, we could start with the minimum feature: only supporting built-in formatters in a configuration. After it is released, this feature can be extended....
I've broken other tests. I'll have a look in the next few days. I'm out for today.
Almost there, @ybiquitous! There are two tests still failing but I think that they may be changed so they pass. Here is one of two (it's the same error): https://github.com/emmacharp/stylelint/blob/9bc35126c63677954dbb28aeecc6efee9cda0325/lib/__tests__/stylelintignore-test/stylelintignore.test.mjs#L234...
@ybiquitous, I've followed your advice, thanks. Only code coverage issues remain in checks. Not sure how to test for it though. Any idea (again)?
@ybiquitous, I think I've addressed all of your concerns. On a sidenote, I feel like you ultimately all but did the work yourself with all this reviewing. I'm sorry (and...
@ybiquitous, there is still a check failing about test coverage. I'm not sure how to test for the line mentioned. Do I have to force getConfigForFile to throw an expected...