Emlyn Bolton

Results 53 comments of Emlyn Bolton

The test was pretty easy to do if you can cut power to the GDO. Cut power to that and your ratgdo board. Wait 2 hours (discharge the wall panel...

@mitchjs yes - esphome version. Happy to grab a PR and work with that.

+1. Alamofire now at 5.2.1 Will have to look for another solution for now

> Big PR, thanks! Some initial feedback that I think should be addressed before I can do a thorough review: > > 1. I think there should be a `CustomMode`...

> > To your first points around breaking those out further, I originally started down this path but stopped as it didn't really help the module be more usable from...

Ok, I found some time :) I've merged the coding / decoding changes in with the existing classes. See what you think of the changes!

> > Speaking of the existing code, it looks like it's not handling dropped packets. My understanding is that if you have a dropped packet you should feed nil into...

> > > > Speaking of the existing code, it looks like it's not handling dropped packets. My understanding is that if you have a dropped packet you should feed...

> > If you look at how you'd be using this, it would be from a jitter buffer. Typically that will just have the read method called periodically as the...

> @emlynmac thanks for your efforts here, I appreciate it. > > I think we should split out decoding dropped packets into a separate thread of work (probably a new...