material-ui-table-edit icon indicating copy to clipboard operation
material-ui-table-edit copied to clipboard

Few upgrades

Open bluesockets opened this issue 7 years ago • 3 comments

Not ready for merge, needs some testing beyond my current use. Here's a rundown for what I've changed:

  • const -> import syntax
  • added default styles: font-size 12px, width 80, padding-left 5
  • column header style override support for font-size, margin-left, width -> (min-width, max-width, width)
  • support for ignoring extra columns data beyond configured header columns
  • converted some map functions to map lookups
  • added default header row id
  • added some styling to tighten up the headers
  • also added delete row icon and action

The project I'm working on needed some slight tweaks that could prove to be useful to the community. Let me know if you'd consider any of these changes - I'm happy to contribute whatever might be useful.

bluesockets avatar Apr 13 '17 03:04 bluesockets

awesome! thanks for contributing. a couple things that would be cool:

  1. const -> import syntax. I'd prefer to keep require syntax because the semantics of the module loader spec are a moving target. Ideally it wouldn't rely on babel stuff, or at least not babel-preset-es2015.

  2. the project is using standard-version to generate the changelog, which means the commit messages need to be made using the conventional commits spec.

I really should put this all down in a contributing.md file and have tests and all that setup. I don't really use this project much, but am willing to add you as a contributor.

emkay avatar Apr 27 '17 19:04 emkay

Sounds good. I'll apply your feedback - require syntax, removing babel-preset-es2015, as well as the changelog with some new commits. Happy to squash my commits for your final review as well.

I'm glad to help!

bluesockets avatar May 23 '17 20:05 bluesockets

@bluesockets I've setup travis-ci. There aren't any tests yet, but it does run the linter.

emkay avatar May 29 '17 03:05 emkay