material-ui-table-edit icon indicating copy to clipboard operation
material-ui-table-edit copied to clipboard

Published 20 hours ago • verified publisher icon emkay

Code style update

Open kavimaluskam opened this issue 7 years ago • 1 comments

I am not sure how do you think about this @emkay Anyway there are some suggestion below:

  1. use import over require
  2. use class extends React.Component over React.createClass
  3. separate the file over few components

kavimaluskam avatar Jul 19 '17 01:07 kavimaluskam

  1. use import over require

My preference would be to use require. I don't really see any benefit in using import. Happy to concede on this point though because it doesn't matter a ton to me either way.

  1. use class extends React.Component over React.createClass

Sure! I have grown to really like class.

  1. separate the file over few components

👍

emkay avatar Jul 19 '17 18:07 emkay