rust-musl-builder icon indicating copy to clipboard operation
rust-musl-builder copied to clipboard

Upgrade base image to Ubuntu 20.04

Open emk opened this issue 4 years ago • 3 comments

Many thanks to @asaaki for having figured out the static link check was returning flase negatives with Alpine's lld. See:

https://github.com/emk/rust-musl-builder/pull/120#issuecomment-803407719

The plan is to merge this when Rust 1.58.0 is released, so people who need 18.04 can stick with1.57.0.

Closes #98. Closes #120.

emk avatar Jan 01 '22 21:01 emk

Now that 1.58.1 is out...

satmandu avatar Feb 01 '22 23:02 satmandu

This is also required to be able to use this container as a base for GitHub Actions, because the checkout action, which is almost always the first action of any build run, requires a newer version of git then is available in Ubuntu 18.04.

hoijui avatar Mar 19 '22 17:03 hoijui

Solution for GitHub Actions: Don't use this docker image, but the normal actions-rs/toolchain action you also use for non-MUSL building, and just add the target property like so:

      - name: "Get the Rust toolchain"
         uses: actions-rs/toolchain@v1
         with:
             toolchain: stable
             override: true
             target: x86_64-unknown-linux-musl
             components: rustfmt, clippy

      - name: "Build manual"
        run: cargo build --verbose --release --target=x86_64-unknown-linux-musl

hoijui avatar Mar 25 '22 10:03 hoijui