emissary icon indicating copy to clipboard operation
emissary copied to clipboard

Support envoy `track_remaining`

Open mohitreddy1996 opened this issue 2 years ago • 3 comments

Please describe your use case / problem. Envoy metrics currently trackable are - https://www.envoyproxy.io/docs/envoy/latest/configuration/upstream/cluster_manager/cluster_stats#circuit-breakers-statistics

except for remaining_*

which can be enabled through setting track_remaining

This currently does not seem to be configurable through Ambassador

Describe the solution you'd like Similar to other circuit breaking configurations, allow configuring this as well

Describe alternatives you've considered There does not seem to be alternatives to this?

mohitreddy1996 avatar Jul 11 '22 19:07 mohitreddy1996

Thanks for this suggestion. Would you be interested in contributing and possibly submitting a PR for this?

cindymullins-dw avatar Jul 16 '22 00:07 cindymullins-dw

Surely :)

Could you point me to a few code pointers which might help me get started?

mohitreddy1996 avatar Jul 16 '22 03:07 mohitreddy1996

I'll try to find out beforehand, but we will have an Emissary Contributors meeting on 8/3 (I believe) at 1pm ET. Any chance you'd be available for that? Are you in our Slack (a8r.io/slack)?

cindymullins-dw avatar Jul 20 '22 22:07 cindymullins-dw

what's the ETA for that?

DanOfir avatar Nov 21 '22 07:11 DanOfir

@mohitreddy1996 , @DanOfir if either of you are interested in contributing to this fix please join our next Emissary Contributors meeting, details noted here.

cindymullins-dw avatar Dec 09 '22 20:12 cindymullins-dw

@LanceEa I'd like to tackle this one

owayss avatar Apr 19 '23 14:04 owayss

@owayss - It was great meeting you at ContribFest yesterday. Let me know if you are still interested in contributing and we can help get the dev tooling sorted out by connecting with us in our Slack #emissary-dev channel

LanceEa avatar Apr 20 '23 08:04 LanceEa