nova-tabs icon indicating copy to clipboard operation
nova-tabs copied to clipboard

Slug field inside tab still doesn't work

Open Brand3000 opened this issue 2 years ago • 8 comments

Just check it

Brand3000 avatar Oct 29 '22 21:10 Brand3000

Excuse me?

marcfil avatar Oct 29 '22 21:10 marcfil

When the slug field is outside of any tab, there's a preview request to the url http://usicn.localhost/nova-api/pages/field/slug/preview However, if the slug is inside, the url is http://usicn.localhost/nova-api/undefined/field/slug/preview undefined instead of pages

Brand3000 avatar Oct 29 '22 21:10 Brand3000

You can watch a video with the issue here https://brand.dn.ua/1.html

Brand3000 avatar Oct 30 '22 22:10 Brand3000

https://github.com/eminiarts/nova-tabs/blob/c9091cf6e8646dfb07cae5dd7fa7ba718f6e1433/resources/js/components/FormTabs.vue#L87

Only relation fields has field.resourceName, I believe it should have use resourceName props instead but not 100% sure.

crynobone avatar Nov 01 '22 05:11 crynobone

I am having the same issue as well. When I move the slug field + the field it is related to outside of a tab then it works. Example field config:

Text::make(__('Title'), 'title')->rules('required'),
Slug::make(__('Slug'), 'slug')->from('title'),

This works, as long as it's not also involving nova-translatable fields, which are having a separate issue related to that plugin: https://github.com/outl1ne/nova-translatable/issues/84

ramonfeleus avatar Dec 13 '22 14:12 ramonfeleus

I'm facing the same problem. Is it possible to merge the PR #292 ?

VGirol avatar Dec 04 '23 08:12 VGirol

I have some problem, please merge the PR https://github.com/eminiarts/nova-tabs/pull/292

bigperson avatar Dec 06 '23 19:12 bigperson