xmltree-rs icon indicating copy to clipboard operation
xmltree-rs copied to clipboard

XMLNode is an unidiomatic type name

Open jplatte opened this issue 4 years ago • 3 comments

It should be called XmlNode, the same way many libraries¹ have a Json type (not JSON), xml has UriMapping instead of URIMapping and so on.

¹ sqlx, actix-web, rocket, ...

jplatte avatar Jan 06 '21 15:01 jplatte

MFEK says there's not one right way to name Rust things.

Json, Uri are ugly, imo…this crate is fine…changing it now would break many downstream users for no benefit.

ctrlcctrlv avatar Jan 25 '22 04:01 ctrlcctrlv

It's part of the official API guidelines that acronyms in type names should not be all-uppercase: https://rust-lang.github.io/api-guidelines/naming.html

MFEK is just as wrong as xmltree.

jplatte avatar Jan 25 '22 08:01 jplatte

cool opinions

ctrlcctrlv avatar Jan 25 '22 08:01 ctrlcctrlv