Andrew Chin

icon location Providence, RI

Results 151 comments of Andrew Chin

Build failed with latest indexmap (2.0.0)

This issue has been fixed in the newly released v0.11.0 version. Thanks to @waywardmonkeys for the fix, and to everyone for your patience

Update `indexmap` to v2

Thank you for this. This will be including in an upcoming 0.11 release

Keep track of attribute namespaces

Thanks for the heads up

Attribute namespaces are not preserved

Thanks for the bump. It sounds like the fix from @ctrlcctrlv in #33 has some good reviews and successful usage in their fork. I'll try to review these changes and...

More general write methods

Something like: ```rust pub fn write_all(w: W, nodes: &[XMLNode]) -> io::Result; ``` ?

[FEAT] Depth First Traversal Methods

Thanks for the PR to start the discussion. I'm interesting in learning more about some of the use-cases you have in mind. A few thoughts in response to your questions:...

[FEAT] Depth First Traversal Methods

In this example you wrote: ```rust let uppercased_comments = root_xml_node.traverse(|xml_node| match xml_node { XMLNode::Comment(comment) => true, _ => false, }).map(|XMLNode::Comment(comment)| comment.to_uppercase()) ``` I like your other suggestion better of using...

[FEAT] Depth First Traversal Methods

Just to confirm: did you mean to close this PR?

`dumbpipe connect` does not close on EOF

For me, a `--close` or `--one-way` option would be a satisfactory solution

`test_all` fails reproducibly on `pasta` `(please report this procfs bug)`

I confirm this is easy to reproduce. The problem is that the mountinfo file for the pasta process looks like this: ``` 1558 1516 0:127 / / ro,nosuid,nodev,noexec,relatime - tmpfs...