emi icon indicating copy to clipboard operation
emi copied to clipboard

Legendary Tooltips Compatibility

Open LTCatt opened this issue 10 months ago • 8 comments

It seems like Legendary Tooltips is unable to correctly get the rarity of items displayed on the EMI, causing it to display as "common rarity" style.

Inventory: image

EMI: image

LTCatt avatar Apr 23 '24 15:04 LTCatt

i think this is related to: https://github.com/emilyploszaj/emi/issues/256

From my own experience, it seems that the borders added by the mod bug with EMI, but not the borders added by Resource Packs, I recommend that you test some, like https://modrinth.com/resourcepack/eclectic-trove-legendary-tooltips

peow avatar Apr 25 '24 19:04 peow

https://github.com/AHilyard/LegendaryTooltips/issues/88 It doesn't look like anyone's gonna fix it :/

LTCatt avatar Apr 26 '24 09:04 LTCatt

Upon investigation, there is event parameter RenderTooltipEvent.Color event in onTooltipColorEvent. In EMI's tooltip, event.getItemStack() returns ItemStack.EMPTY, which causes this bug. So I think this is on EMI's side...

LTCatt avatar Apr 30 '24 21:04 LTCatt

I built a very crude mixin that build a ItemStack from the translation key and passes it to Legendary Tooltips, which does get around the bug, but it's not a good solution. Tooltips.zip

LTCatt avatar Apr 30 '24 21:04 LTCatt

interesting

peow avatar May 01 '24 21:05 peow

Was this every fixed or addressed? How would I as a user use that mixin?

Burgersim avatar Jun 08 '24 09:06 Burgersim

you can't just use it. you have to complie it into a mod :/

LTCatt avatar Jun 08 '24 10:06 LTCatt

Is there a compiled mod file? I really want to use emi and Legendary Tooltips together

wsxiya avatar Aug 29 '24 06:08 wsxiya