modem icon indicating copy to clipboard operation
modem copied to clipboard

Published 20 hours ago • verified publisher icon emilsedgh

auto encoding

Open alexislg2 opened this issue 9 years ago • 5 comments

If encoding is not specified this PR can choose the best one for you

alexislg2 avatar Sep 11 '14 17:09 alexislg2

@alexislg2 I think this patch belongs to pdu package. What do you think?

emilsedgh avatar Sep 15 '14 20:09 emilsedgh

Why not but you have to keep the possibility for the user using modem.js of not having to select an encoding

(exactly like your mobile phone does: you type your text, select a recipient and it chooses the encoding for you depending of the characters in your text)

alexislg2 avatar Sep 16 '14 08:09 alexislg2

I agree that the patch is useful. All I'm saying is that pdu.js should do it, not modem.

emilsedgh avatar Sep 16 '14 09:09 emilsedgh

OK On Sep 16, 2014 11:38 AM, "Emil Sedgh" [email protected] wrote:

I agree that the patch is useful. All I'm saying is that pdu.js should do it, not modem.

Reply to this email directly or view it on GitHub https://github.com/emilsedgh/modem/pull/9#issuecomment-55718957.

alexislg2 avatar Sep 16 '14 10:09 alexislg2

But il will only work if you also merge my PR on pdu.js for using GSM 7-bit alphabet

alexislg2 avatar Sep 16 '14 13:09 alexislg2